-
Notifications
You must be signed in to change notification settings - Fork 647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Disable DateTimeFormat::formatToParts for Apple platform (#1155)" #1567
Conversation
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
ceaea5d
to
86bc065
Compare
@cipolleschi has updated the pull request. You must reimport the pull request before landing. |
86bc065
to
439aadb
Compare
@cipolleschi has updated the pull request. You must reimport the pull request before landing. |
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
439aadb
to
cb6ecca
Compare
@cipolleschi has updated the pull request. You must reimport the pull request before landing. |
cb6ecca
to
355f514
Compare
@cipolleschi has updated the pull request. You must reimport the pull request before landing. |
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
355f514
to
d2efad0
Compare
@cipolleschi has updated the pull request. You must reimport the pull request before landing. |
d2efad0
to
a93edbc
Compare
@cipolleschi has updated the pull request. You must reimport the pull request before landing. |
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
…)" This reverts commit c5a633f.
a93edbc
to
4fb9498
Compare
@cipolleschi has updated the pull request. You must reimport the pull request before landing. |
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
@cipolleschi merged this pull request in ac557bb. |
Summary
This reverts commit c5a633f.
That commit removed the Intl.DateTimeFormat.formatToParts for Apple platforms from Hermes.
However, the community started depending on it, and we ended up manually reverting that commit in the release branch for the past 3 releases.
This is like reverting the commit in main, so we are proceeding with that approach to simplify the release process of React Native and Hermes to the OSS.
Test Plan
CI